Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip filename with a path element in the skip list #3198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Collaborator

@DimitriPapadopoulos DimitriPapadopoulos commented Nov 3, 2023

  • Start with a test that shows failure to skip argument /path/to/ingoredir with --skip=ignoredir.
  • Then fix the test by skipping filename /path/to/ingoredir with a path element in the skip list (--skip=ignoredir)

Fixes #3196 (comment).

@DimitriPapadopoulos DimitriPapadopoulos changed the title Test we properly skip argument when relevant Skip filename with a path element in the skip list Nov 3, 2023
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review November 3, 2023 17:41
@DimitriPapadopoulos
Copy link
Collaborator Author

@larsoner Can you have a look? This PR should fix #3196 reported by @yarikoptic.

@larsoner
Copy link
Member

larsoner commented Nov 4, 2023

Tests are failing after a very long timeout.

  1. Can you see why?
  2. One possibility is that while never exits. I usually prefer for ii in range (100): ... or similar just in case something misbehaves.
  3. Can you change the timeout on the jobs to be like 10-20 minutes? For example like this: https://github.com/mne-tools/mne-python/blob/ec87fd8976a82ef7541c3114cd7955083eb278d6/.github/workflows/tests.yml#L20

@DimitriPapadopoulos
Copy link
Collaborator Author

Strange, it did work from the command line, but probably before I changed the existing code into a function 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Interaction" with pre-commit: ideally should skip the skipped files.
2 participants