Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictionary: Plural of critical is still critical #2580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vikivivi
Copy link
Contributor

@vikivivi vikivivi commented Nov 2, 2022

@DimitriPapadopoulos DimitriPapadopoulos added the dictionary Changes to the dictionary label Nov 2, 2022
@peternewman
Copy link
Collaborator

Genuine question, as I begin to doubt myself:
There are five critical and two warning alerts, all the criticals are equally important, which one do you deal with first?

I guess it should maybe be "all the critical alerts..."

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Nov 3, 2022

I suppose you could use the pronoun ones in formal English: all the critical ones.

See 'one' and 'ones' or One and Ones. But of course, ones is missing from most dictionaries. Sigh.

Also, when referring to well-known groups of people, no plural for (collective) adjectives.

On the other hand, from Common errors with adjectives and adverbs in English:

Some adjectives – especially “others” – can be used in plural form, if the noun was mentioned earlier (and is not directly after the adjective). Here are two examples:

  • I have many pairs of shoes, but these red shoes are my favorites.
    (= favorite shoes)
  • The boss gave raises to some employees but not others.
    (= other employees)
  • Some of the shows on this channel are great, and others are terrible.
    (= other shows on this channel)

However, I believe this doesn't work with most adjectives:

  • We have many alerts, but the red alerts are the criticals.

@vikivivi
Copy link
Contributor Author

vikivivi commented Nov 4, 2022

There are five critical and two warning alerts, all the criticals are equally important, which one do you deal with first?

There are five critical and two warning alerts, all the critical alerts are equally important, which one do you deal with first?

critical is an adjective.
There are 5 red cars.
There are 5 critical alerts.
There are 5 critical vulnerabilities.

@skangas
Copy link
Collaborator

skangas commented Nov 20, 2022

Perhaps this is something for the informal dictionary?

@jwilk
Copy link
Contributor

jwilk commented Jan 2, 2023

The plural of "critical" is of course "criticals":
https://en.wiktionary.org/wiki/critical#Noun

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Jan 2, 2023

@jwilk We were not able to find critical as a noun in any dictionary, see #2580 (comment).

@DimitriPapadopoulos
Copy link
Collaborator

In GitHub, I believe “criticals” mostly refer to “critical hits” in games.

I would say it's up to end-users to skip this fix if they have to.

@luzpaz
Copy link
Collaborator

luzpaz commented Mar 3, 2023

What's the final verdict on this ?

@DimitriPapadopoulos
Copy link
Collaborator

I guess it could be moved to dictionary_code.txt. Most occurrences of criticals refer to “critical hits” in games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants