Don't test under JDK 24

[mernst]

Summary by CodeRabbit

• Chores

  • Removed JDK 24 CI targets and Docker image recipes, trimming the test matrix.
  • Switched gating guidance to a canary-based model centered on JDK 25 and activated a testingSuffix variable.
  • Enabled preprocessor comment expansion in CI templates.

• Tests

  • Eliminated JDK 24 test and typecheck variants across CI providers; coverage for supported versions (including JDK 25) is preserved.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Removes JDK 24 CI jobs, Dockerfiles, and upload references across Azure Pipelines and CircleCI; updates M4 templates/comments to use a canary_version (25) gating scheme and adjusts dependency guidance to drive execution by canary_jobs; preserves remaining JDK25 and other job logic. (39 words)

Changes

Cohort / File(s)	Summary of Changes
Azure pipeline removals & gating .azure/azure-pipelines.yml, .../.azure/azure-pipelines.yml.m4, .../.azure/jobs.m4, .../.azure/defs.m4	Deleted all JDK24 jobs (Ubuntu/Rocky) including Ubuntu typecheck JDK24 entries; replaced jdk-version-centric dependsOn guidance with canary_version / canary_jobs tokens (canary_version = 25); activated testingSuffix variable; added M4 changecom to enable expansion in comments.
CircleCI removals & template update .circleci/config.yml, .../.circleci/config.yml.m4, .../.circleci/defs.m4	Removed JDK24 job definitions and workflow references for Ubuntu/Rocky across quick/nonquick/non-txt/misc/kvasir and Ubuntu typecheck; removed 24-based job_dependences entries; added M4 changecom to enable expansion in comments.
Dockerfile/script removals scripts/Dockerfile-README, scripts/Dockerfile-ubuntu-jdk24, scripts/Dockerfile-ubuntu-jdk24-plus, scripts/Dockerfile-rockylinux-jdk24, scripts/Dockerfile-rockylinux-jdk24-plus	Removed create_upload_docker_image calls for jdk24/jdk24-plus in README script and deleted Dockerfile recipes that built Ubuntu/Rocky images containing OpenJDK 24 (including “-plus” variants).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Commit/PR
  participant M4 as M4 templates
  participant CI as CI Orchestrator
  participant Canary as canary_jobs (JDK25)
  participant Matrix as Remaining jobs (JDK25 + others)

  Dev->>M4: Update templates (changecom, replace jdk24 with canary_version)
  Dev->>CI: Push/PR with updated configs

  CI->>Canary: Run canary_jobs (JDK25)
  alt canary success
    CI->>Matrix: Run remaining jobs (JDK25 and others)
  else canary failure
    CI--xMatrix: Skip remaining jobs
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Use JDK 25 as the canary version #648 — CI pipeline changes shifting canary logic and removing JDK24 job entries.
• Don't test under JDK 24 #665 — Removes JDK24 CI jobs and Dockerfiles and updates M4 templates to use canary_version tokens.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "Don't test under JDK 24" succinctly and accurately summarizes the primary change — removal of JDK 24 test jobs, Dockerfiles, and CI workflow references — and is clear and specific enough for a reviewer scanning history to understand the intent.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7caf120 and d270935.

📒 Files selected for processing (3)

• .circleci/config.yml (0 hunks)
• .circleci/config.yml.m4 (1 hunks)
• .circleci/defs.m4 (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d502099 and cdc4749.

📒 Files selected for processing (5)

• .azure/azure-pipelines.yml (1 hunks)
• .azure/azure-pipelines.yml.m4 (1 hunks)
• .azure/jobs.m4 (0 hunks)
• .circleci/config.yml (0 hunks)
• .circleci/config.yml.m4 (0 hunks)

💤 Files with no reviewable changes (3)

• .azure/jobs.m4
• .circleci/config.yml.m4
• .circleci/config.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: codespecs.daikon (kvasir_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nonquick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (misc_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (quick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nontxt_ubuntu_jdk25)

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cdc4749 and 0df1942.

📒 Files selected for processing (7)

• .azure/azure-pipelines.yml (1 hunks)
• .azure/azure-pipelines.yml.m4 (1 hunks)
• scripts/Dockerfile-README (0 hunks)
• scripts/Dockerfile-rockylinux-jdk24 (0 hunks)
• scripts/Dockerfile-rockylinux-jdk24-plus (0 hunks)
• scripts/Dockerfile-ubuntu-jdk24 (0 hunks)
• scripts/Dockerfile-ubuntu-jdk24-plus (0 hunks)

💤 Files with no reviewable changes (5)

• scripts/Dockerfile-ubuntu-jdk24-plus
• scripts/Dockerfile-README
• scripts/Dockerfile-rockylinux-jdk24
• scripts/Dockerfile-rockylinux-jdk24-plus
• scripts/Dockerfile-ubuntu-jdk24

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: codespecs.daikon (misc_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nonquick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (quick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nontxt_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (kvasir_ubuntu_jdk25)

[coderabbitai]

Actionable comments posted: 5

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.azure/azure-pipelines.yml.m4 (1)

31-37: Azure canary dependsOn set is complete; mirror in CircleCI.

You gate on quick/nonquick/nontxt/misc/kvasir + both typecheck jobs. CircleCI’s canary-jobs currently only requires bundled. Add latest there for consistency.

If desired, I can open a PR patching .circleci/config.yml.m4 accordingly.

♻️ Duplicate comments (1)

.azure/azure-pipelines.yml (1)

22-23: Comment fix LGTM and the wildcard before jdk21 is present.

Matches prior guidance; generated plan is clear.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0df1942 and 790d171.

📒 Files selected for processing (5)

• .azure/azure-pipelines.yml (1 hunks)
• .azure/azure-pipelines.yml.m4 (2 hunks)
• .azure/defs.m4 (1 hunks)
• .circleci/config.yml.m4 (1 hunks)
• .circleci/defs.m4 (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: codespecs.daikon (typecheck_bundled_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nonquick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nontxt_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (misc_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (quick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (kvasir_ubuntu_jdk25)
• GitHub Check: build