forked from awy5ocki/helix-solver
-
Notifications
You must be signed in to change notification settings - Fork 2
PL splitter integration #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
codespaghettifier
wants to merge
58
commits into
codespaghettifier:main
from
tboldagh:pl-splitter-integration
Closed
PL splitter integration #5
codespaghettifier
wants to merge
58
commits into
codespaghettifier:main
from
tboldagh:pl-splitter-integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed box definitions to float
…ly qOverPt and Phi
TBox and script
* Separated AccumulatorSection into a standalone class, added unit test and CMakeFiles * Deep refactor * Refactor of scripts for adaptive processing illustrations * Mainly refactor plotting scipts * More updates to the algorithm and drawing scipts * More updates to the algorithm and drawing scipts * Improved docu * Fixed lines count condition, improved cells drawing * Drop dead code, added more connets for future dev
* Separated AccumulatorSection into a standalone class, added unit test and CMakeFiles * Deep refactor * Refactor of scripts for adaptive processing illustrations * Mainly refactor plotting scipts * More updates to the algorithm and drawing scipts * More updates to the algorithm and drawing scipts * Improved docu * Fixed lines count condition, improved cells drawing * Drop dead code, added more connets for future dev * Renamed Stub to point
* Prepared env for oneAPI * Compiling with SYCL * Fix to CMakeLists.txt
* Conditional DEBUG added, optimized Accumulator_Lines, added cell solution limits for the lines histogram * Added functionality to save ROOT file (for larger scale perfromance tests) * Resolved conflicts II * resolved conflicts III --------- Co-authored-by: Stefan Horodenski <shorodenski@student.agh.edu.pl> Co-authored-by: tboldagh <tomasz.bold@gmail.com> Co-authored-by: Tomasz Bold <68424406+tboldagh@users.noreply.github.com>
Co-authored-by: Stefan Horodenski <shorodenski@student.agh.edu.pl>
…dges (#10) * Added ODD speciifc RZ exclussion regions * Added functions to divide measurement points into z phi wedges
* Reconstruction efficiency * Added macro plotting histogram of truth and Hough pt and phi * Added macro plotting divisionLevel histogram * Updates after PR II * Resolved conflicts * Reconstruction efficiency for single muon * Deleted input files + minor changes --------- Co-authored-by: Stefan Horodenski <shorodenski@student.agh.edu.pl>
* Assign value to ACC_*_PRECISION from config.json * Solve options deliver to kernel --------- Co-authored-by: Stefan Horodenski <shorodenski@student.agh.edu.pl> Co-authored-by: tboldagh <tomasz.bold@gmail.com>
* Events filter based on hits * Fix
- added description of scripts
* Assign value to ACC_*_PRECISION from config.json * Solve options deliver to kernel * Improved file for accumulator plots (lines, solutions, colors) * Number of solutions for different precision * Updated scripts, Filtering_Analysis --------- Co-authored-by: Stefan Horodenski <shorodenski@student.agh.edu.pl> Co-authored-by: tboldagh <tomasz.bold@gmail.com>
* Assign value to ACC_*_PRECISION from config.json * Solve options deliver to kernel * Improved file for accumulator plots (lines, solutions, colors) * Number of solutions for different precision * Updated scripts, Filtering_Analysis --------- Co-authored-by: Stefan Horodenski <shorodenski@student.agh.edu.pl> Co-authored-by: tboldagh <tomasz.bold@gmail.com>
* Assign value to ACC_*_PRECISION from config.json * Solve options deliver to kernel * Improved file for accumulator plots (lines, solutions, colors) * Number of solutions for different precision * Updated scripts, Filtering_Analysis * Added Gauss filtering --------- Co-authored-by: Stefan Horodenski <shorodenski@student.agh.edu.pl> Co-authored-by: tboldagh <tomasz.bold@gmail.com>
* Assign value to ACC_*_PRECISION from config.json * Solve options deliver to kernel * Improved file for accumulator plots (lines, solutions, colors) * Number of solutions for different precision * Updated scripts, Filtering_Analysis * Added Gauss filtering * Region division opimalization * Resolved conflicts II --------- Co-authored-by: Stefan Horodenski <shorodenski@student.agh.edu.pl> Co-authored-by: tboldagh <tomasz.bold@gmail.com>
* Testing data splitting kernel * Test data transfer time * Random points * Transform to cylindrical * Issue with splitting * Played with splitting * Remove binary * Adaptations for SYCL * Refactored around order check * phi wrapping at +pi fixed * Switch to proper FMA * Count sections buffer size with wider counter
* Add missing files * Added sorter header
* Code optimization, removing std::vector * Solved error for pileup
* Testing data splitting kernel * fix conflicts
* Update README.md - added description of scripts * Linear fit, pileup efficiency * Variable bin width
Move all files to 'old directory in preparation for the new prject structure and build system.
Add build.sh build script responsible for building the application, tools, and tests.
Add InstallBuildRun.md documentation for installation, environment preparation, building, running, and running tests.
Add source_setvars.sh script to facilitate sourcing environment variables for SYCL. Modify build.sh to use source_setvars.sh.
Add FileStructure.md, a guideline for new file structure of the project.
Add top-level CMakeLists.txt. It introduces new build system based on components/libraries of structure compliant with the new file structure. CmakeLists.txt is used by build.sh to build the application, tools, and tests. When used, it also generates TestSuitesList.txt in the build directory. TestSuitesList.txt is intended to be used for running tests with run_test.py script which will be added later.
AvailableDevicesInfo is a tool used to easily check what devices able to run SYCL applications are available. Devices are listed by name and printed to stdout, one per line. The program is supposed to be used by show_devices.sh.
Add run_test.sh - a script running all unit tests present in the applicaton and framework, based on build/TestSuitesList.txt.
Add SYCL flags to CMAKE_CXX_FLAGS Add CUDA to $PATH
Add ConstSizeVector - a container with subset of functionality of std::vector. It operates on an array of size determined at the compile time. Intened to be std::vector substiture for use in SYCL kernels.
Copy Splitter from old/experimental/ to the new file stucture. Make changes necessary for compilation with SYCL.
Simplify phi_wrap funciton. Minor formatting changes to experimental/Splitter.
Usage of std::exp caused linking errors. Replace them with sycl::exp. Works as long as -g option for icpx is not set. Change device selector to GPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.