Use prop-types from npm module, not React

[mihaiblaga89]

No description provided.

[codeslayer1]

Hi @mihaiblaga89 ,

Can you please specify the purpose of this pull request? What benefits will prop-types library serve instead of using the native React.Proptypes?

[mihaiblaga89]

Because it's deprecated.

[codeslayer1]

Oh. Saw this just now.

Thanks. Will merge the pull request soon and update on Npm.

[mihaiblaga89]

Thanks. Good work with the module. As a quick question, you have scriptUrl argument, that takes an actual URL. Is there any way to give the ckeditor.js as a file? I tried require('../../[...]ckeditor.js') but it does not work. I would avoid to have ckeditor folder exposed to the world. Thanks

[codeslayer1]

I haven't tried loading a local file actually. I use load-script module to load external script(creditor.js in our case). Will have to check if it can load a local file URL. Will let you know in sometime.

[codeslayer1]

I just checked, it won't be possible to load the script using a local url because eventually the script should be publicly accessible so that it can be loaded on client's end.

[mihaiblaga89]

Thanks. In theory it can be bundled by webpack or something, but I don't have the time to mess with it at the moment. It works as it is, if this will become a problem later on I'll jump in. Thanks again

[codeslayer1]

Yup. In case you use webpack or any other bundler, you can bundle it with your other files. But doing this in the library would be an overkill and would bloat an otherwise simple library. And Thanks for contributing.

In case you are interested in tech related discussions, you can join my group here on slack - https://goo.gl/QGyfyC