[SHIP-2296] Switch to using gcloud auth print-access-token | docker login ... instead of gcloud docker -a
#57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this is failing here (probably due to stale creds), I've verified that the dockercfg-generator tests work with Docker 20.10. |
jglick
changed the title
gcloud auth configure-docker instead of gcloud docker -agcloud auth configure-docker instead of gcloud docker -a
… work. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
force-pushed
the
gcloud-auth-configure-docker
branch
from
0eb91f0 to
3d931f2
Compare
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
changed the title
gcloud auth configure-docker instead of gcloud docker -agcloud auth print-access-token | docker login ... instead of gcloud docker -a
joesiewert
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.