feat: sandpack template type #1075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
This PR removes
codesandbox-import-util-typesinternal dependency to be Apache 2.0 license compliant 🎉More detail inside #1073 discussion 🙂
What is the current behavior?
Codesandbox uses its own
ITemplateinterface fromcodesandbox-import-util-typesdependency which is under LGPL 3.0 license.What is the new behavior?
Rename
TemplatetoSandpackTemplatetype to stay consistent with other sandpack types.However,
SandpackClientonly supports currentTemplatetype. So we can clean the old type and simply reuse the currentSandpackTemplate🙂What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
templatepropertyChecklist
typecheckcommand