fix(context-menu): use parent privacy on fork #8447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
CompuIves
requested changes
May 13, 2024
| v2?: boolean; | ||
| title?: string; | ||
| privacy?: 0 | 1 | 2; | ||
| privacy?: number; |
Member
There was a problem hiding this comment.
Hmm, shouldn't this be 0 | 1 | 2? I thought it's nice to encode in the type that it can only be one of these three values.
Contributor
Author
There was a problem hiding this comment.
I changed that because there is a mismatch type between GraphQL and our types. Unfortunately, the backend can't return a specific type like 0 | 1 | 2 but number, making the application use the less restrict one.
Alternatively, I could only cast the place with the mismatch type to 0 | 1| 2 instead of changing the main function parameter.
CompuIves
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.