Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create sandbox from standalone modal #8403

Merged
merged 10 commits into from
Mar 25, 2024
Merged

feat: create sandbox from standalone modal #8403

merged 10 commits into from
Mar 25, 2024

Conversation

CompuIves
Copy link
Member

Couple of changes:

  • Folder & privacy are now coupled to each-other
  • We can create sandboxes from the standalone modal
  • We can pass in a minimum privacy

@CompuIves CompuIves requested a review from alexnm March 22, 2024 16:07
@codesandbox CodeSandbox
Copy link

codesandbox bot commented Mar 22, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

alexnm
alexnm requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@alexnm alexnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few thoughts on the changes

packages/app/src/app/components/Create/CreateBox.tsx Outdated Show resolved Hide resolved
packages/app/src/app/components/Create/CreateBox.tsx Show resolved Hide resolved
packages/app/src/app/overmind/namespaces/editor/actions.ts Outdated Show resolved Hide resolved
@CompuIves CompuIves requested a review from alexnm March 25, 2024 11:35
alexnm
alexnm previously approved these changes Mar 25, 2024
View reviewed changes
@CompuIves CompuIves merged commit 4327b03 into master Mar 25, 2024
12 of 15 checks passed
@CompuIves CompuIves deleted the draft/musing-mountain branch March 25, 2024 13:57
@sentry-io Sentry.io
Copy link

sentry-io bot commented Mar 27, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of null (reading 'status') CreateBoxForm(src/app/components/Create/CreateB... View Issue
  • ‼️ AxiosError: Request aborted <object>.post(src/app/overmind/effects/api/apiF... View Issue

Did you find this useful? React with a 👍 or 👎

alexnm
alexnm reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@alexnm alexnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pester-by-codesandbox[bot]
pester-by-codesandbox bot approved these changes Apr 16, 2024
View reviewed changes
Copy link

@pester-by-codesandbox pester-by-codesandbox bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A collaborator issued an after-the-fact review beginning with the 👍 emoji, so this PR is now approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexnm alexnm alexnm left review comments

@pester-by-codesandbox pester-by-codesandbox[bot] pester-by-codesandbox[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CompuIves @alexnm