Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: issue with npm fetcher in sandpack, looks stuck in a loop (#8361) #8387

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Revert "fix: issue with npm fetcher in sandpack, looks stuck in a loop (#8361) #8387

merged 1 commit into from
Mar 13, 2024

Conversation

CompuIves
Copy link
Member

Fixes #8384

Tested the repro case without this change, and it worked again. I think we might be returning too early somewhere here.

@CompuIves CompuIves requested a review from DeMoorJasper March 13, 2024 09:49
@codesandbox CodeSandbox
Copy link

codesandbox bot commented Mar 13, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@CompuIves CompuIves merged commit 2d67187 into master Mar 13, 2024
4 of 7 checks passed
@CompuIves CompuIves deleted the revert/resolver-change branch March 13, 2024 09:50
DeMoorJasper added a commit that referenced this pull request Mar 13, 2024
@DeMoorJasper
Revert "Revert "fix: issue with npm fetcher in sandpack, looks stuck …
b79a69a 
…in a loop (#8361)" (#8387)"

This reverts commit 2d67187.
@DeMoorJasper DeMoorJasper mentioned this pull request Mar 13, 2024
Merged
alexnm
alexnm reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@alexnm alexnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pester-by-codesandbox[bot]
pester-by-codesandbox bot approved these changes Mar 14, 2024
View reviewed changes
Copy link

@pester-by-codesandbox pester-by-codesandbox bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A collaborator issued an after-the-fact review beginning with the 👍 emoji, so this PR is now approved.

CompuIves pushed a commit that referenced this pull request Mar 14, 2024
@DeMoorJasper
fix: npm fetcher improvement + regression fix (#8392)
b231049 
* Revert "Revert "fix: issue with npm fetcher in sandpack, looks stuck in a loop (#8361)" (#8387)"

This reverts commit 2d67187.

* fix: always invalidate the package we're fetching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexnm alexnm alexnm left review comments

@pester-by-codesandbox pester-by-codesandbox[bot] pester-by-codesandbox[bot] approved these changes

@DeMoorJasper DeMoorJasper Awaiting requested review from DeMoorJasper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "Could not find module in path" error on an attempt to load a package that contains esm and cjs modules
2 participants
@CompuIves @alexnm