Skip to content

fix: pass on query params when redirecting to v2 #8309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

CompuIves
Copy link
Member

Fixes #8299

When redirecting to v2, we were not passing on the query params. Because of this, e.g. the file parameter would get lost.

Tested this on the dev server inside CodeSandbox, now it's passed along.

@CompuIves CompuIves requested review from danilowoz and alexnm January 30, 2024 18:07
Copy link

codesandbox bot commented Jan 30, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CompuIves CompuIves enabled auto-merge (squash) January 30, 2024 22:21
@CompuIves CompuIves disabled auto-merge January 31, 2024 08:57
@CompuIves CompuIves merged commit fc92e0c into master Jan 31, 2024
@CompuIves CompuIves deleted the draft/wonderful-snowflake branch January 31, 2024 08:57
Copy link
Contributor

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link

@pester-by-codesandbox pester-by-codesandbox bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A collaborator issued an after-the-fact review beginning with the 👍 emoji, so this PR is now approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define API query parameter regression
3 participants