[WIP] Add font family to preferences

[viankakrisna]

Add font family for preference. AFAIK this should be all from the client side, haven't got to test it yet until we have staging server :)

Also, why do we need to injectGlobal here @CompuIves ? I think we can move it to CodeContainer?

[CompuIves]

Really nice, I was able to get 'Arial' in my code editor hahaha. Okay great, I had to add one preference option to work with strings (only supported boolean and number until now), check this commit: 9942d3f.

Would be great to move the styles to CodeContainer, I never liked injectGlobal very much.

[CompuIves]

Can you also add a description underneath the Preference option?

[viankakrisna]

ah yes, I'm not aware that it's only accepted boolean and number. 😄 Updated with 9942d3f, description, and the moving of style to CodeContainer

[CompuIves]

Haha, a coincidence. I'm currently implementing Prettier Preferences and now need the Preference type refactor too. Let me take a look.

[CompuIves]

Looks good! I made one small change to add specify a placeholder ('Source Code Pro') in the input, makes it more clear on what to input. I think that's enough for the user to see what needs to happen, so we can remove the description.

I added the last required commit here: bf114d8.

And this is how it looks like:

Then it'll be ready to merge! Thanks a lot for this PR, this is very valuable.

[CompuIves]

Great! Let's ship this 🚀

[CompuIves]

Oh oops, forgot to change the name. Well, 🤷‍♂️

[viankakrisna]

😅 you move really fast! thank you!

[CompuIves]

Haha, thanks. I'm thinking of replacing the preferences system for something that takes less boilerplate, now you need to change 4 things before it works. Very confusing and tedious.

[viankakrisna]

yup, I missed some things when I first opened the PR. Today I just use this for forms shameless plug plain react and lodash 😄

[CompuIves]

Hmm, interesting. If we could convert the preferences to something like that it would be really nice.

Best case would be if we only had to define preferences in the store, and then it automatically gets synced with localStorage when updated.

[viankakrisna]

maybe under one action? SET_PREFERENCE, and just validate the preference schema for that action payload.

[CompuIves]

Yap, that's even better.