fix(sandpack): accurately resolve GitHub versions in jsdelivr fetcher #7133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old method did not accurately resolve jsdelivr urls for github repos with a supplied version. Hard coded `master` meta pulling made the versioning obsolete, and repos without a `master` branch didn't work at all. This update makes it possible to accurately pull specific release versions from GitHub repos, and the default branch is fetched from the repository meta.
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 738c96b:
|
3 tasks
|
Build for latest commit 738c96b is at https://pr7133.build.csb.dev/s/new. |
lio-tl
approved these changes
Nov 11, 2022
wiledal
changed the title
wiledal
changed the title
CompuIves
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix 🐛
What is the current behavior?
Old method did not accurately resolve jsdelivr urls in
package.jsonfor GitHub repos with a supplied version (egusername/repo#1.2.3orusername/repo@branch). Hard codedmastermeta fetching made the versioning obsolete, and repos without amasterbranch didn't work at all.Issue can be seen here https://codesandbox.io/s/r3-rapier-branding-test-8e257y?file=/package.json
More info an digging here:
#6514 (comment)
What is the new behavior?
This update makes it possible to accurately pull specific release versions from GitHub repos, and the default branch is fetched from the repository meta instead of defaulting to
master.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
yarn test, all tests are still passing, nothing changed hereChecklist