Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use document.write to write html files #702

Merged
merged 23 commits into from
May 20, 2018
Merged

Use document.write to write html files #702

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4b13107
Use document.write to write html files
Apr 7, 2018
dcee10d
Merge remote-tracking branch 'upstream/master' into document-write
lbogdan May 13, 2018
16b3da0
Nove the handling of external resources
CompuIves May 13, 2018
99b646f
Tweaks
CompuIves May 13, 2018
d5b88ed
Add extra check
CompuIves May 13, 2018
2548e7f
Revert change on irrelevant file
CompuIves May 13, 2018
6b80361
Merge branch 'master' into document-write
CompuIves May 13, 2018
a127ce8
Add TODO
CompuIves May 14, 2018
8802c99
Merge branch 'master' into document-write
CompuIves May 20, 2018
b098824
Fix external resource loading
CompuIves May 20, 2018
08041fe
Remove unnecessary async statement
CompuIves May 20, 2018
48112a8
Fix waiting for individual external resources
CompuIves May 20, 2018
c1387c5
Add onerror listener
CompuIves May 20, 2018
57363f5
Add dummy script
CompuIves May 20, 2018
9c2ee43
Replace the document instead of creating new one
CompuIves May 20, 2018
457ed39
Use document.write based on code type
CompuIves May 20, 2018
e82d586
Put ext resources loading as last
CompuIves May 20, 2018
f406c2a
Temporary fix
CompuIves May 20, 2018
aad5337
Solve html updating with UI
CompuIves May 20, 2018
176e79d
Change message to more friendly one
CompuIves May 20, 2018
d65ad4f
Fix lint
CompuIves May 20, 2018
2767076
Replace resize listeners
CompuIves May 20, 2018
262afbe
Use shorthand property for html
CompuIves May 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put ext resources loading as last
  • Loading branch information
@CompuIves
CompuIves committed May 20, 2018
commit e82d586ebdf179fe3e8451a948c4b155d1a135a9
8 changes: 4 additions & 4 deletions packages/app/src/sandbox/compile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,10 +480,6 @@ async function compile({
}
}

const extDate = Date.now();
await handleExternalResources(externalResources);
debug('Loaded external resources in ' + (Date.now() - extDate) + 'ms');

if (!manager.webpackHMR && !manager.preset.htmlDisabled) {
const htmlModulePath = templateDefinition
.getHTMLEntries(configurations)
Expand Down Expand Up @@ -513,6 +509,10 @@ async function compile({
lastHTML = html;
}

const extDate = Date.now();
await handleExternalResources(externalResources);
debug('Loaded external resources in ' + (Date.now() - extDate) + 'ms');

await manager.preset.setup(manager);

const tt = Date.now();
Expand Down