Skip to content

Conversation

@danilowoz
Copy link
Contributor

You were absolutely right about the method to determine the env 😓

@danilowoz danilowoz requested a review from lbogdan June 28, 2021 09:14
@danilowoz danilowoz self-assigned this Jun 28, 2021
@lbogdan
Copy link
Contributor

lbogdan commented Jun 28, 2021

Build for latest commit 936e162 is at https://pr5933.build.csb.dev/s/new.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 936e162:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr5933 June 28, 2021 09:28 Inactive
@lbogdan lbogdan temporarily deployed to pr5933 June 28, 2021 09:36 Inactive
@lbogdan lbogdan temporarily deployed to pr5933 June 28, 2021 09:44 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jun 28, 2021

Let's use the same logic as for SSE:

const getSSEUrl = (sandbox?: Sandbox, initialPath: string = '') =>
`https://${sandbox ? `${sandbox.id}.` : ''}sse.${
process.env.NODE_ENV === 'development' || process.env.STAGING
? sseDomain
: host()
}${initialPath}`;
.

@lbogdan lbogdan temporarily deployed to pr5933 June 28, 2021 10:43 Inactive
@lbogdan lbogdan temporarily deployed to pr5933 June 28, 2021 13:17 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jun 28, 2021

LGTM

@danilowoz danilowoz merged commit 9c0d24b into master Jun 28, 2021
@danilowoz danilowoz deleted the fix/ab-env branch June 28, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants