chore: use gatsby-remark-embedder fully to transform all embeds in docs
#5658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
changed the title
gatsby-remark-embedder fully to transform all embeds in docs
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 92a2f8b:
|
Contributor
|
Build for latest commit 92a2f8b is at https://pr5658.build.csb.dev/s/new. |
danilowoz
suggested changes
May 12, 2021
Contributor
danilowoz
left a comment
danilowoz
left a comment
There was a problem hiding this comment.
Hey @MichaelDeBoey, thanks for your contribution! However, it doesn't really work (see my comments). Would you like to care of this, or can we close this?
MichaelDeBoey
force-pushed
the
use-gatsby-remark-embedder-fully
branch
from
653ef4b to
e5a3f28
Compare
MichaelDeBoey
force-pushed
the
use-gatsby-remark-embedder-fully
branch
from
e5a3f28 to
92a2f8b
Compare
Contributor
Author
|
@danilowoz All tests are green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use
gatsby-remark-embedderin some places, but we're not using it fully (yet).