Skip to content

add vim to FF #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020
Merged

add vim to FF #4831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...es/app/src/app/pages/common/Modals/PreferencesModal/EditorPageSettings/EditorSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { VSCodePlaceholder } from '../VSCodePlaceholder';
import { PreferenceContainer } from '../elements';

const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
const isFF = navigator.userAgent.toLowerCase().includes('firefox');

export const EditorSettings: FunctionComponent = () => {
const {
Expand Down Expand Up @@ -45,7 +44,7 @@ export const EditorSettings: FunctionComponent = () => {

{/* {Vim mode does not work on FF or Safari */}
<Element marginTop={4}>
<PreferenceContainer disabled={isSafari || isFF}>
<PreferenceContainer disabled={isSafari}>
<Preference
title="Enable VIM extension"
type="boolean"
Expand All @@ -65,9 +64,9 @@ export const EditorSettings: FunctionComponent = () => {
</PreferenceContainer>
</Element>

{isSafari || isFF ? (
{isSafari ? (
<Text block marginBottom={2} marginTop={2} size={2} variant="muted">
The VIM extension currently only works on Chrome and Microsoft Edge.
The VIM extension currently does not work on Safari
</Text>
) : null}

Expand Down