-
Notifications
You must be signed in to change notification settings - Fork 2.4k
🔨 Cleanup components package #4068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Cleanup components package #4068
Conversation
MichaelDeBoey
commented
May 2, 2020
- Cleanup dependencies
- Update dependencies to latest version
- Remove double exported components
- Cleanup Storybook config
- Cleanup package.json
- Cleanup ignore files
|
Build for latest commit 3064c05 failed. |
240bff4 to
f97fafd
Compare
9737b6e to
4022633
Compare
SaraVieira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey!
I reverted the package.json because it may not be a good idea to update dependencies in here as it's used everywhere, can you please revert the yarn.lock? I can't do it from the UI
|
@SaraVieira I only removed the unused packages and updated all other packages to their latest minor version, so this shouldn't be a problem |
ae1aa59 to
98e6fa9
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3064c05:
|
|
Michael we shouldn't update stuff just like that, pls revert the package.json, updates to used things should be super well tested before |
|
@SaraVieira I've reverted the deletion and update of dependencies |
9df42e9 to
3064c05
Compare
|
Hey! I am so sorry but at this point I can't really understand what is happening and why it's failing, I am gonna close, feel free to start it over cause this one just became super old :/ |