Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

  • Cleanup dependencies
  • Update dependencies to latest version
  • Remove double exported components
  • Cleanup Storybook config
  • Cleanup package.json
  • Cleanup ignore files

@lbogdan
Copy link
Contributor

lbogdan commented May 2, 2020

Build for latest commit 3064c05 failed.

@lbogdan lbogdan temporarily deployed to pr4068 May 2, 2020 22:13 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/components/base branch from 240bff4 to f97fafd Compare May 2, 2020 22:43
@lbogdan lbogdan temporarily deployed to pr4068 May 2, 2020 22:54 Inactive
@lbogdan lbogdan temporarily deployed to pr4068 May 2, 2020 23:04 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/components/base branch from 9737b6e to 4022633 Compare May 2, 2020 23:32
@lbogdan lbogdan temporarily deployed to pr4068 May 2, 2020 23:40 Inactive
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

I reverted the package.json because it may not be a good idea to update dependencies in here as it's used everywhere, can you please revert the yarn.lock? I can't do it from the UI

@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira I only removed the unused packages and updated all other packages to their latest minor version, so this shouldn't be a problem

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/components/base branch from ae1aa59 to 98e6fa9 Compare May 21, 2020 18:38
@MichaelDeBoey MichaelDeBoey requested a review from SaraVieira May 21, 2020 18:38
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3064c05:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr4068 May 21, 2020 18:47 Inactive
@SaraVieira
Copy link
Contributor

Michael we shouldn't update stuff just like that, pls revert the package.json, updates to used things should be super well tested before

@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira I've reverted the deletion and update of dependencies

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/components/base branch from 9df42e9 to 3064c05 Compare July 3, 2020 13:42
@SaraVieira
Copy link
Contributor

Hey!

I am so sorry but at this point I can't really understand what is happening and why it's failing, I am gonna close, feel free to start it over cause this one just became super old :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants