Cleanup new dashboard Start + Templates #3953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
changed the title
|
Build for latest commit 18cc7a2 is at https://pr3953.build.csb.dev/s/new. |
jyash97
reviewed
Apr 21, 2020
| } | ||
|
|
||
| const templates = data && data.me && data.me.templates; | ||
| const templates = data.me.templates; |
There was a problem hiding this comment.
I guess this was an intentional check as we have seen crash reports. Also, in my opinion it will be good to have a defensive code so that it doesn't break in the future.
There was a problem hiding this comment.
Like I said in my review (#3952 (comment)), we know we don't have an error or loading at this point.
This means data is present.
Since data is an object with a me object (which has a templates array), we can simplify the code to what I've done
|
closing this as a lot as changed and we are still not done :( |
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves my PR review #3952 (review)