Skip to content

Conversation

@jyash97
Copy link
Contributor

@jyash97 jyash97 commented Apr 19, 2020

What kind of change does this PR introduce?

Bug Fix

What is the current behavior?

After deleting the folder in the dashboard, the view is not updated.

Ref: https://www.loom.com/share/e4c2b3be5fa54e38ac7e3b17cc5210f1

What is the new behavior?

Update view after deleting

Ref: https://www.loom.com/share/33fc94ee6bdf49bab1a733938f5e9f81

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Locally tested by deleting folders

Checklist

  • Testing
  • Ready to be merged

@lbogdan
Copy link
Contributor

lbogdan commented Apr 19, 2020

Build for latest commit 297f1f8 is at https://pr3942.build.csb.dev/s/new.

@MichaelDeBoey
Copy link
Contributor

I'm not sure if the provided solution is the best one, since that' relying on the URL structure, rather then the folder structure.
I think getting the parent and going to its link is a more correct and more sustainable way tbh.

@CompuIves
Copy link
Member

Yep, though currently in terms of UI we also don't keep a parent (we just keep a string which is a path). We're revamping the dashboard more, so I think this is a good intermediate fix that we can put live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants