feat: add copy sandbox link option on Sandbox Card #3886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyash97
changed the title
|
Build for latest commit 9d1a58a is at https://pr3886.build.csb.dev/s/new. |
SaraVieira
reviewed
Apr 13, 2020
| export const DELETE_SANDBOX_DROP_KEY = 'delete'; | ||
| export const MAKE_TEMPLATE_DROP_KEY = 'makeTemplate'; | ||
|
|
||
| const copyToClipboard = (str: string) => { |
There was a problem hiding this comment.
This is awesome! But we already have this function here:
You can call it from Overmind with effects.browser.copyToClipboard and passing the string
Let me know if you need any help
There was a problem hiding this comment.
Hey 👋
Thanks for the quick review, will make this change in some time.
There was a problem hiding this comment.
As we have not refactored these Component yet so is there a way to access effects in Class Components? I was thinking to access the util by useOvermind hook but this won't work here.
There was a problem hiding this comment.
You are very right!
I will merge it!
Thank you!
SaraVieira
approved these changes
Apr 14, 2020
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enhancement
What is the current behavior?
We cannot get/copy the sandbox link from the dashboard. Usecase: I wanted to share a link of old codesandbox so I searched on the dashboard and had to open the sandbox to get the link.
What is the new behavior?
Add an option to copy the link directly from Context Menu.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Locally tested 4-5 sandboxes link by copying the link from the above option.
Checklist