Dialog: Replies loader #3781
Merged
Dialog: Replies loader #3781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for latest commit 3f13333 is at https://pr3781.build.csb.dev/s/new. |
christianalfoni
requested changes
Mar 30, 2020
packages/app/src/app/pages/Sandbox/Editor/Workspace/screens/Comments/Dialog/index.tsx
Outdated
Show resolved
Hide resolved
MichaelDeBoey
suggested changes
Mar 30, 2020
| ); | ||
| const Replies = ({ replies, repliesRenderedCallback }) => { | ||
| const [isAnimating, setAnimating] = React.useState(true); | ||
| const repliesLoaded = !!replies[0]; |
There was a problem hiding this comment.
Suggested change
| const repliesLoaded = !!replies[0]; | |
| const repliesLoaded = Boolean(replies[0]); |
| const SKELETON_HEIGHT = 146; | ||
|
|
||
| React.useEffect(() => { | ||
| if (repliesLoaded && !isAnimating) repliesRenderedCallback(); |
There was a problem hiding this comment.
Suggested change
| if (repliesLoaded && !isAnimating) repliesRenderedCallback(); | |
| if (repliesLoaded && !isAnimating) { | |
| repliesRenderedCallback(); | |
| } |
Comment on lines
+5
to
+6
| // export interface ITextProps extends React.HTMLAttributes<HTMLSpanElement> {} | ||
|
|
There was a problem hiding this comment.
Suggested change
| // export interface ITextProps extends React.HTMLAttributes<HTMLSpanElement> {} |
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist