fix issue with updating line #3767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompuIves
reviewed
Mar 27, 2020
| const moduleModel = this.moduleModels[model.uri.path]; | ||
| const moduleModel = | ||
| this.moduleModels[model.uri.path] || | ||
| this.getModuleModelByPath(model.uri.path.replace('/sandbox', '')); |
There was a problem hiding this comment.
Doesn't it make sense to completely remove this.moduleModels[model.uri.path] and enforce that we use getModuleModelByPath?
|
Build for latest commit 48dbb57 is at https://pr3767.build.csb.dev/s/new. |
|
This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.