Skip to content

Conversation

@tanmoyopenroot
Copy link
Contributor

@tanmoyopenroot tanmoyopenroot commented Mar 23, 2020

What kind of change does this PR introduce?

feat #2813

What is the current behavior?

No shortcut available for opening or closing the console like in vscode

What is the new behavior?

Added shortcut to toggle console ctrl + Backtick

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

The testing was done visually.

  1. Open the a new sandbox http://localhost:3000/s/new
  2. Press ctrl + Backtick which will open the console.
  3. And on again pressing ctrl + Backtick will close the console.

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@lbogdan
Copy link
Contributor

lbogdan commented Mar 23, 2020

Build for latest commit 64e0a43 is at https://pr3738.build.csb.dev/s/new.

Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you so much!

@SaraVieira SaraVieira merged commit 0f6a29a into codesandbox:master Mar 25, 2020
@tanmoyopenroot tanmoyopenroot deleted the 2813-feat-add-console-shortcut branch March 26, 2020 01:24
@MichaelDeBoey MichaelDeBoey linked an issue Mar 26, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement shortcut for popping up terminal or console

3 participants