Fix: Icons cant be on scale #3689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed this one with Danny and realised that our icons can't be on the 4pt scale
Example:
The button that contains both these icons is the same size - 26x26, but the icons inside them have to be adjusted based how they look next to each other
Because of that, they can't always be 16. or even be on the 8/12/16 scale we have. We need more granular control of them
The ones in the image are 14x14 and 10x10 to look optically aligned. (both inside a 26x26 button)
Notes for future: It would be cool to optically align icons in the library so that there are less scenarios in which we need to optically align them. This can't be abstracted away fully because optical alignment depends on the context/neighbouring icons, so we'll always need this escape hatch 🙃