New modals #3673
Merged
New modals #3673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit 3b32bcc is at https://pr3673.build.csb.dev/s/new. |
Contributor
|
Oh, there are a lot of changes here 😂 I have extracted what modals are affected:
|
MichaelDeBoey
suggested changes
Mar 11, 2020
packages/app/src/app/pages/common/Modals/DeploymentModal/index.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/common/Modals/DeploymentModal/index.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/common/Modals/SignInForTemplates/index.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/common/Modals/DeleteDeploymentModal/index.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/common/Modals/PickSandboxModal/index.tsx
Outdated
Show resolved
Hide resolved
MichaelDeBoey
suggested changes
Mar 11, 2020
Co-Authored-By: Michaël De Boey <info@michaeldeboey.be>
Member
|
Added Danny as well for a design review, you can test here @DannyRuchtie: https://pr3673.build.csb.dev/s/new |
Member
|
Is there a way to remove this blue border here?
|
Member
|
|
MichaelDeBoey
suggested changes
Mar 13, 2020
packages/app/src/app/pages/common/Modals/StorageManagementModal/FilesList/index.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Michaël De Boey <info@michaeldeboey.be>
Contributor
Author
|
@CompuIves Both issues fixed I didn't touch the dependencies and preferences modals in terms of design changes |
MichaelDeBoey
previously requested changes
Mar 16, 2020
packages/app/src/app/pages/Sandbox/Editor/ForkFrozenSandboxModal/ForkFrozenSandboxModal.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/ForkFrozenSandboxModal/ForkFrozenSandboxModal.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/ForkFrozenSandboxModal/ForkFrozenSandboxModal.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/ForkFrozenSandboxModal/ForkFrozenSandboxModal.tsx
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/ForkFrozenSandboxModal/ForkFrozenSandboxModal.tsx
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/ForkFrozenSandboxModal/ForkFrozenSandboxModal.tsx
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/ForkFrozenSandboxModal/ForkFrozenSandboxModal.tsx
Show resolved
Hide resolved
Co-Authored-By: Michaël De Boey <info@michaeldeboey.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the modals into the new design system
Progress
https://www.notion.so/Modals-81994d4cb5d44c8899b284638d8eaf84