Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(homepage): Second picked sandbox doesn't open in explore #1715

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

tinahir
Copy link
Contributor

@tinahir tinahir commented Apr 4, 2019

What kind of change does this PR introduce?
Fix issue #1699 where Second picked sandbox doesn't open in explore sandcodebox

What is the current behavior?
#1699

What is the new behavior?
Able to open second picked sandbox in popup and navigate to left and right with new sandbox

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@SaraVieira
Copy link
Contributor

@all-contributors please add @tinahir for code

@allcontributors
Copy link
Contributor

@SaraVieira

We had trouble processing your request. Please try again later.

@SaraVieira
Copy link
Contributor

@all-contributors please add @tinahir for code

@allcontributors
Copy link
Contributor

@SaraVieira

I've put up a pull request to add @tinahir! 🎉

@allcontributors
Copy link
Contributor

@SaraVieira

I've updated the pull request to add @tinahir! 🎉

@CompuIves
Copy link
Member

Thank you @tinahir!!

@CompuIves CompuIves merged commit d0014c9 into codesandbox:master Apr 4, 2019
@tinahir tinahir deleted the fix-explore-sendbox branch April 4, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants