Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook #1645

Closed
wants to merge 18 commits into from
Closed

Storybook #1645

wants to merge 18 commits into from

Conversation

SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Mar 22, 2019

Adds an instance of storybook

http://striped-storybook-123.surge.sh

@SaraVieira SaraVieira force-pushed the storybook branch 5 times, most recently from 7b890e2 to e2b0221 Compare March 22, 2019 20:48
@SaraVieira SaraVieira requested a review from CompuIves March 22, 2019 20:55
@SaraVieira SaraVieira marked this pull request as ready for review March 22, 2019 20:56
@libetl
Copy link
Contributor

libetl commented Mar 26, 2019

@ndelangen Look at this

@SaraVieira
Copy link
Contributor Author

https://codesandbox-storybook.now.sh

New Link

@SaraVieira SaraVieira force-pushed the storybook branch 2 times, most recently from a430fc0 to fbe2e4b Compare March 30, 2019 18:54
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@siddharthkp
Copy link
Contributor

siddharthkp commented May 20, 2019

Tried setting this up locally, the error I get is:

/codesandbox-client/node_modules/serve-favicon/index.js:55
    throw new TypeError('path to favicon.ico is required')
    ^

TypeError: path to favicon.ico is required

It doesn't seem to fall back on the default storybook favicon 🤷‍♀

It's coming from storybook/core. After some digging it looks storybook expects a staticDir in options which it couldn't figure out 🤔

@SaraVieira Any clue here?

@SaraVieira
Copy link
Contributor Author

Hey @siddharthkp

So I updated all the yarns, and fixed all the conflicts and seems to have fixed the issue

I did find something I forgot to tell you: You need two panes open running:

yarn start:common

and

yarn start:storybook

Because storybook uses the built files
Ping me with any more issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants