-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search Improvements #1609
Search Improvements #1609
Conversation
cc @Haroenv |
The sorting of "relevance" and "views" seems very similar to me, was a different sort required for this? I'm seeing some flashes when I change index, but I don't see any particular reason why in the code by a quick glance, maybe it already was there before Also, it seems like the search is pretty hidden with the new design, I can't seem to find any link towards it anymore, I had to guess the URL. Finally there's a small other thing (maybe only on Safari), and that's the search icon isn't correctly positioned: |
Good points! I deleted the views one as that is basically the default one and also added a link to the search in the header The other two: The flickering seems to only happen on safari :/ I'm looking at the CSS thing now |
The bottom part of the card (with description) seems a bit big to me, does it have different styles compared to |
@CompuIves Nop, itmay be because most of them don't have a description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This super clean! I left some minor comments. I also think that it would be indeed better to change the background color to what we have on the explore page. Curious what that looks like.
import { Container } from './elements'; | ||
|
||
function Filters() { | ||
return ( | ||
<Container> | ||
<Sort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a user test it was pointed we can't order the search and it makes sense to do so
This PR adds order by likes and views
This PR also:
selectSandbox
instead ofpickSandbox
to make it more genericDesign
https://www.figma.com/file/akq4c3BMhkW5EHipeIBEbKmf/Search-Page?node-id=0%3A1