Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional parameters to zeit deployment #1542

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

oroce
Copy link
Contributor

@oroce oroce commented Feb 14, 2019

What kind of change does this PR introduce?
feature

What is the current behavior?
Right now it's impossible to add additional parameters to zeit deployment like env or region even though I'd add to the now.json.

What is the new behavior?
With this change all the supported parameters which are listed on the zeit documentation are supported.

Checklist:

  • Documentation n/a
  • Tests - help needed
  • Ready to be merged
  • Added myself to contributors table

Right now it's impossible to add additional parameters to zeit deployment like `env` or `region` even though I'd add to the `now.json`. With this change all the supported parameters which are listed on the [zeit documentation](https://zeit.co/docs/api#endpoints/deployments) are supported.
Also I fixed the table because the previous contributor `Abdullah` wasn't visible.
@SaraVieira SaraVieira merged commit 4b24193 into codesandbox:master Feb 15, 2019
@SaraVieira
Copy link
Contributor

Thank you!!! This really helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants