fix error overlay #120
Merged
fix error overlay #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error overlay now uses normal flow and inserts an additional line for error information. So no overlay of text and info caret occur any longer.
|
Wow that was quick! Thanks a lot! Could you add yourself to the contributors? You can do this by running |
CompuIves
reviewed
Aug 16, 2017
| } | ||
| } | ||
|
|
||
| function absolutifyCaret(component: Node) { |
There was a problem hiding this comment.
I think we could remove this whole function, right?
There was a problem hiding this comment.
Oh wait, now that I see it, maybe we could delete this whole file? Or does this contain functionality to position the caret horizontally?
There was a problem hiding this comment.
you are right, no additional logic remains. Removed the file and cleaned up. Thx for the detailed review.
|
Just tested it, works great! The only standing thing is that I think we could delete |
|
Great, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error overlay now uses normal flow and inserts an additional line for error information. So no overlay of text and info caret occur any longer.
fixes #117