[Fix] Renaming directories (#867)

* Edit -> Rename * Only rename files if the title changed
codesandbox · May 29, 2018 · 177c621 · 177c621
1 parent d24cd32
commit 177c621
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.../app/src/app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/Entry/EditIcons/index.js b/.../app/src/app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/Entry/EditIcons/index.js
@@ -39,7 +39,7 @@ function EditIcons({
       {(hovering || (window.__isTouch && active) || forceShow) && (
         <Container>
           {onEdit && (
-            <Tooltip title="Edit">
+            <Tooltip title="Rename">
               <Icon onClick={handleClick(onEdit)}>
                 <EditIcon />
               </Icon>

diff --git a/packages/app/src/app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/Entry/index.js b/packages/app/src/app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/Entry/index.js
@@ -41,11 +41,13 @@ class Entry extends React.PureComponent {
     this.setState({ error: isInvalidTitle });
   };
 
-  handleRename = (title, force) => {
-    const { shortid } = this.props;
-    const canRename = !this.handleValidateTitle(title);
+  handleRename = (newTitle, force) => {
+    const { shortid, title } = this.props
+    if (newTitle === title) return
+
+    const canRename = !this.handleValidateTitle(newTitle);
     if (canRename && this.props.rename) {
-      this.props.rename(shortid, title);
+      this.props.rename(shortid, newTitle);
       this.resetState();
     } else if (force) this.resetState();
   };