Skip to content

Completed addition function #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Conversation

NicholasChoong
Copy link
Member

Change Summary

  • Created an addition function

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

@NicholasChoong NicholasChoong self-assigned this Jun 24, 2023
@Drewbi
Copy link

Drewbi commented Jun 24, 2023

Is this in scope for the project?

Copy link
Collaborator

@scratchclaggy scratchclaggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@NicholasChoong
Copy link
Member Author

Why yeah not

@APM246
Copy link

APM246 commented Jun 24, 2023

rubbish

def test_add():
assert add(1, 1) == 2
assert add(0, 0) == 0
assert add(1, -1) == 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't cover the -1, -1 case

@NicholasChoong NicholasChoong requested a review from Drewbi June 24, 2023 06:33
Copy link

@Drewbi Drewbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NicholasChoong NicholasChoong merged commit c14946d into main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants