Skip to content

+ Mathieu GP #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2021
Merged

+ Mathieu GP #20

merged 4 commits into from
Jul 6, 2021

Conversation

mathieugp
Copy link
Contributor

Ma fiche.

@mathieugp mathieugp requested review from rngadam and carms-ng June 28, 2021 18:55
@mathieugp
Copy link
Contributor Author

@Carms-dev For some reason I do not appear as a new team member in the deployment preview above. What did I do wrong?

@carms-ng
Copy link
Contributor

carms-ng commented Jul 1, 2021 •
edited
Loading

@Carms-dev For some reason I do not appear as a new team member in the deployment preview above. What did I do wrong?

Hi @mathieugp, did you add this image -> 003_mathieu_gauthier_pilote.jpg <- to src/assets/images/portraits directory?

@mathieugp
Copy link
Contributor Author

mathieugp commented Jul 5, 2021 •
edited
Loading

Hi @mathieugp, did you add this image -> 003_mathieu_gauthier_pilote.jpg <- to src/assets/images/portraits directory?

@Carms-dev : Now I have. :-)

@carms-ng
Copy link
Contributor

carms-ng commented Jul 5, 2021 •
edited
Loading

Hi @mathieugp, did you add this image -> 003_mathieu_gauthier_pilote.jpg <- to src/assets/images/portraits directory?

@Carms-dev : Now I have. :-)

Great! Deploy looks good. If you want your bio to appear in french as well, you can add the corresponding strings to -> locales/fr/team.fr.json

Otherwise, good to merge :)

@mathieugp
Copy link
Contributor Author

@Carms-dev : Translation added. Good to merge! :-)

@carms-ng carms-ng merged commit 97b44c6 into main Jul 6, 2021
@carms-ng carms-ng deleted the teams+mathieugp branch July 6, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carms-ng carms-ng carms-ng approved these changes

@rngadam rngadam Awaiting requested review from rngadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieugp @carms-ng