This repository was archived by the owner on May 9, 2020. It is now read-only.
Python 3 support #38
Merged
Python 3 support #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No license found, adding one.
maratkomarov
force-pushed
the
feature/FAM-102
branch
from
e18dba3 to
f03f341
Compare
PyChef now supports both Python 2/3. New dependency `six` for 2/3 compatibility
maratkomarov
force-pushed
the
feature/FAM-102
branch
from
1fa2db2 to
c4a89a0
Compare
maratkomarov
force-pushed
the
feature/FAM-102
branch
from
efaebbd to
1962698
Compare
|
As it stands this has a ton of semantics changes on Python 2. It would need massive cleanup to be viable. A good start though! |
| @@ -80,7 +87,7 @@ def __init__(self, url, key, client, version='0.10.8', headers={}): | |||
| self.key = key | |||
| self.client = client | |||
| self.version = version | |||
| self.headers = dict((k.lower(), v) for k, v in headers.iteritems()) | |||
| self.headers = dict((k.lower(), v) for k, v in headers.items()) | |||
There was a problem hiding this comment.
This would have to use six.iteritems to match semantics on Python 2. This is a common issue below so not pointing out each instance.
maratkomarov
force-pushed
the
feature/FAM-102
branch
from
111d2c4 to
1c0751e
Compare
maratkomarov
force-pushed
the
feature/FAM-102
branch
from
1c0751e to
e093c26
Compare
|
@coderanger we've spread |
|
Awesome, thanks for doing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Python 2 / 3 support