feature: cloudcmd: Prevent unselect being fired on panel click when in mobile view #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderaiser
reviewed
Oct 29, 2024
coderaiser
reviewed
Oct 29, 2024
hagaygo
force-pushed
the
disable-selection-reset-on-mobile-ui
branch
from
94f3df1
to
524c2ef
Compare
|
Changed the code to use new execIfNotMobile as you suggested, to use a function which does the check for is mobile UI. |
coderaiser
reviewed
Oct 30, 2024
This was referenced Oct 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #418
This will prevent "unselect" being called on panel click when in mobile view (determined by the hard coded screen width).
Tested the full scenario locally on my mobile and it works just fine.