Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Added support for gpt-4 128k #494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimmystridh
Copy link

@jimmystridh jimmystridh commented Nov 7, 2023

With yesterday's release GPT-4 128k is available in the API. Updated limits (but left default) with the new values from https://help.openai.com/en/articles/8555510-gpt-4-turbo

Summary by CodeRabbit

  • New Feature: Added support for the new GPT-4 128k model in the TokenLimits class. This update allows users to utilize the increased token limit and response tokens of the GPT-4 model, enhancing the capabilities of their AI applications. Please note that the knowledgeCutOff value has also been updated for this model.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Image description CodeRabbit

Walkthrough

This change introduces support for the new GPT-4 128k model in the TokenLimits class. It adds a case for the gpt-4-1106-preview model, setting appropriate token limits and updating the knowledge cut-off value. The default values remain unaffected.

Changes

File Summary
src/limits.ts Updated TokenLimits class to include support for the new GPT-4 128k model. Added a case for gpt-4-1106-preview, set maxTokens to 128000, responseTokens to 4000, and updated knowledgeCutOff. Default values remain unchanged.

🐇💻

In the land of code, where the shadows lie,

A new model emerges, reaching for the sky.

With tokens aplenty, it's ready to fly,

GPT-4 is here, oh my, oh my! 🚀🎉


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 44244a9 and b06f11f commits.
Files selected (1)
  • src/limits.ts (1)
Files ignored due to filter (1)
  • dist/index.js
Files skipped from review due to trivial changes (1)
  • src/limits.ts
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@harjotgill
Copy link
Contributor

@jimmystridh thanks for your PR. We tried the new model yesterday and found that it’s severely rate limited right now - 100 requests per day (100 RPD). We can merge this PR as soon as the limit is increased by OpenAI. Cheers!

@jimmystridh
Copy link
Author

https://www.threads.net/@firtoz/post/Cze1ZLmorg3/?igshid=NTc4MTIwNjQ2YQ== seems like it's happening

@kuzaxak
Copy link

kuzaxak commented Nov 17, 2023

Limits raised to 10,000 RPD. I think it's time to merge.

@harjotgill

@mopemope
Copy link

@harjotgill When will this be merged?

@a6a18
Copy link

a6a18 commented Jan 30, 2024

Let's make this happen together!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants