Skip to content

Remove buildcc base namespace and complete documentation #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jan 20, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
d7fc226
Removed toolchain from namespace buildcc::base and added it to buildcc
coder137 Jan 16, 2022
9750ee8
Update test_toolchain_verify.cpp
coder137 Jan 16, 2022
596515d
Changed TargetEnv namespace from buildcc::base to buildcc
coder137 Jan 17, 2022
3a0abe2
Updated TargetConfig and TargetFileExt namespace from buildcc::base t…
coder137 Jan 17, 2022
427d384
Shifted TargetType from namespace buildcc::base to buildcc
coder137 Jan 17, 2022
a3d0bdb
Shifted TargetState namespace from buildcc::base to buildcc
coder137 Jan 17, 2022
b9bb12a
Shifted BuilderInterface from buildcc::base to buildcc::internal
coder137 Jan 17, 2022
3f31473
Shifted Generator from namespace buildcc::base to buildcc
coder137 Jan 17, 2022
97dc77b
Update target.rst
coder137 Jan 17, 2022
2ff11a3
Shift Api CRTP class from buildcc::base to buildcc::internal
coder137 Jan 18, 2022
7603e0d
Update target_info.h
coder137 Jan 18, 2022
e739d9e
Shifted TargetGetter namespace from buildcc::base to buildcc::internal
coder137 Jan 18, 2022
7e95a6a
Renamed buildcc::base::Target to buildcc::BaseTarget
coder137 Jan 18, 2022
3df4c24
Migrated Target from namespace buildcc::base to buildcc
coder137 Jan 18, 2022
687d07a
Updated CompileObject, CompilePch and LinkTarget namespace from build…
coder137 Jan 18, 2022
b0b6654
Minor naming updates
coder137 Jan 18, 2022
0301d50
Updated toolchain documentation
coder137 Jan 18, 2022
0fb0907
Updated specialized toolchain documentation
coder137 Jan 18, 2022
a148ff5
Updated generator documentation
coder137 Jan 18, 2022
6f595f9
Added target_utils
coder137 Jan 19, 2022
8570f82
Updated generator.rst
coder137 Jan 19, 2022
ec5f7bc
Updated target_utils with TargetFileExt and TargetConfig
coder137 Jan 19, 2022
ea9fa67
Update target_config.h
coder137 Jan 19, 2022
c35726c
Updated environment APIs
coder137 Jan 19, 2022
20b99d5
Update target_config.h
coder137 Jan 19, 2022
5a98122
Update target_config.h
coder137 Jan 19, 2022
9a44e20
Update target.rst
coder137 Jan 19, 2022
929e1cb
Update target.rst
coder137 Jan 19, 2022
ab43c57
Update target.rst
coder137 Jan 19, 2022
5602a77
Updated target utils
coder137 Jan 19, 2022
dc7086a
Update target.rst
coder137 Jan 19, 2022
71d7abc
Update TODO.md
coder137 Jan 19, 2022
9c04fb8
Update namespaces.rst
coder137 Jan 19, 2022
dea0296
Update target.rst
coder137 Jan 20, 2022
99e1219
Added compile.toml, immediate.toml and README for single example
coder137 Jan 20, 2022
0319d2a
Update testing.rst
coder137 Jan 20, 2022
9e0db6c
Update environment.rst
coder137 Jan 20, 2022
1bb7bd3
Update walkthroughs.rst
coder137 Jan 20, 2022
638bcfe
Update target_info.h
coder137 Jan 20, 2022
8a58fb8
Update target.h
coder137 Jan 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated CompileObject, CompilePch and LinkTarget namespace from build…
…cc::base to buildcc::internal
  • Loading branch information
coder137 committed Jan 18, 2022
commit 687d07a75369ba3dcdcb51ae8b3f7a3baa0ecbee
4 changes: 2 additions & 2 deletions buildcc/lib/target/include/target/friend/compile_object.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Target;

}

namespace buildcc::base {
namespace buildcc::internal {

class CompileObject {

Expand Down Expand Up @@ -80,6 +80,6 @@ class CompileObject {
tf::Task compile_task_;
};

} // namespace buildcc::base
} // namespace buildcc::internal

#endif
4 changes: 2 additions & 2 deletions buildcc/lib/target/include/target/friend/compile_pch.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class Target;

}

namespace buildcc::base {
namespace buildcc::internal {

class CompilePch {
public:
Expand Down Expand Up @@ -84,6 +84,6 @@ class CompilePch {
tf::Task task_;
};

} // namespace buildcc::base
} // namespace buildcc::internal

#endif
4 changes: 2 additions & 2 deletions buildcc/lib/target/include/target/friend/link_target.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class Target;

}

namespace buildcc::base {
namespace buildcc::internal {

class LinkTarget {
public:
Expand Down Expand Up @@ -58,6 +58,6 @@ class LinkTarget {
tf::Task task_;
};

} // namespace buildcc::base
} // namespace buildcc::internal

#endif
12 changes: 6 additions & 6 deletions buildcc/lib/target/include/target/target.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ class Target : public internal::BuilderInterface,
env::TaskState GetTaskState() const noexcept { return task_state_; }

private:
friend class base::CompilePch;
friend class base::CompileObject;
friend class base::LinkTarget;
friend class internal::CompilePch;
friend class internal::CompileObject;
friend class internal::LinkTarget;

friend class TargetGetter<Target>;

Expand Down Expand Up @@ -146,9 +146,9 @@ class Target : public internal::BuilderInterface,
internal::TargetLoader loader_;

// Friend classes
base::CompilePch compile_pch_;
base::CompileObject compile_object_;
base::LinkTarget link_target_;
internal::CompilePch compile_pch_;
internal::CompileObject compile_object_;
internal::LinkTarget link_target_;

// Task states
tf::Task target_start_task_;
Expand Down
4 changes: 2 additions & 2 deletions buildcc/lib/target/src/target/friend/compile_object.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ constexpr const char *const kInput = "input";

} // namespace

namespace buildcc::base {
namespace buildcc::internal {

void CompileObject::AddObjectData(const fs::path &absolute_source_path) {
const fs::path absolute_object_path =
Expand Down Expand Up @@ -266,4 +266,4 @@ void CompileObject::RecompileSources(
}
}

} // namespace buildcc::base
} // namespace buildcc::internal
4 changes: 2 additions & 2 deletions buildcc/lib/target/src/target/friend/compile_pch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ void AggregateToFile(const fs::path &filename,

} // namespace

namespace buildcc::base {
namespace buildcc::internal {

// PUBLIC

Expand Down Expand Up @@ -163,4 +163,4 @@ void CompilePch::PreCompile() {
target_.storer_.current_pch_files.Convert();
}

} // namespace buildcc::base
} // namespace buildcc::internal
4 changes: 2 additions & 2 deletions buildcc/lib/target/src/target/friend/link_target.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ constexpr const char *const kCompiledSources = "compiled_sources";
constexpr const char *const kLibDeps = "lib_deps";
} // namespace

namespace buildcc::base {
namespace buildcc::internal {

// PUBLIC

Expand Down Expand Up @@ -105,4 +105,4 @@ void LinkTarget::BuildLink() {
}
}

} // namespace buildcc::base
} // namespace buildcc::internal
4 changes: 2 additions & 2 deletions buildcc/lib/target/src/target/tasks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ void Target::StartTask() {

} // namespace buildcc

namespace buildcc::base {
namespace buildcc::internal {

// 1. User adds/removes/updates pch_headers
// 2. `BuildCompile` aggregates pch_headers to a single `buildcc_header` and
Expand Down Expand Up @@ -169,7 +169,7 @@ void LinkTarget::Task() {
task_.name(kLinkTaskName);
}

} // namespace buildcc::base
} // namespace buildcc::internal

namespace buildcc {

Expand Down
2 changes: 1 addition & 1 deletion buildcc/lib/target/test/target/test_compile_object.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ static buildcc::Toolchain gcc(buildcc::Toolchain::Id::Gcc, "gcc", "as", "gcc",
TEST(TargetCompileObjectTestGroup, CacheCompileCommand_Invalid) {
buildcc::BaseTarget target("CacheCompileCommand_Invalid",
buildcc::TargetType::Executable, gcc, "data");
buildcc::base::CompileObject object(target);
buildcc::internal::CompileObject object(target);

object.AddObjectData("random.invalid");

Expand Down