fix(templates): fix terraform errors

[phorcys420]

Problem

Now that scripts/terraform_validate.sh validates templates (from #948), running terraform validate across the registry surfaces pre-existing breakages in 14 coder/* templates. This PR fixes all of them so they pass validation.

Fixes

Unsupported agent_name argument (dominant issue)

• Removed agent_name from code-server / windows_rdp module calls and from coder_app / coder_env / coder_script / coder_agent_instance resources. Only the jetbrains and filebrowser modules actually declare an agent_name variable, so those usages are left intact.

Invalid jetbrains module source

• registry.coder.com/modules/coder/jetbrains/coder (5 components — invalid) → registry.coder.com/coder/jetbrains/coder.

windows_rdp stray argument

• Removed resource_id = null (no longer a supported argument).

aws-devcontainer region module

• Replaced the raw source = "https://registry.coder.com/modules/aws-region" URL with the proper registry source registry.coder.com/coder/aws-region/coder + version = "~> 1.0".

gcp-devcontainer agent reference

• Fixed module calls referencing the non-existent coder_agent.main; the agent in that template is coder_agent.dev (count-based), so they now use coder_agent.dev[0].id.

incus provider schema drift

• incus_volume → incus_storage_volume
• incus_cached_image → incus_image (object-form source_image = { remote, name })
• Dropped the unsupported incus_instance_file resource; the agent token is now delivered via cloud-init write_files (consistent with how the init script and systemd units are already delivered).
• Moved instance limits into config (limits.cpu / limits.memory) and updated coder_metadata references accordingly.

Validation

All 14 previously-failing templates now pass terraform validate:

aws-devcontainer, aws-linux, azure-linux, azure-windows, digitalocean-linux,
docker, docker-devcontainer, gcp-devcontainer, gcp-linux, gcp-vm-container,
kubernetes, nomad-docker, scratch, incus  → all Success

terraform fmt / prettier applied. No .terraform artifacts or lockfiles committed.

Note

Changes are confined to template main.tf files. The incus rework in particular adapts to the current lxc/incus provider schema; the token-via-cloud-init approach matches the sibling bpmct/incus-* templates.

Generated with Mux.