fix(dotfiles): allow tilde (~) in git repository URLs#763
Merged
DevelopmentCats merged 1 commit intomainfrom Feb 26, 2026
Merged
fix(dotfiles): allow tilde (~) in git repository URLs#763DevelopmentCats merged 1 commit intomainfrom
DevelopmentCats merged 1 commit intomainfrom
Conversation
The URL validation regex was rejecting URLs containing tilde characters, which are commonly used in Bitbucket Server for user repositories (e.g. ssh://git@bitbucket.example.org:7999/~username/repo.git). Adds ~ to the allowed character set in all three validation regexes and adds a test case for tilde URLs. Fixes #762
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The URL validation regex in the dotfiles module was rejecting URLs containing tilde (
~) characters, which are commonly used in Bitbucket Server for user repositories (e.g.ssh://git@bitbucket.example.org:7999/~username/repo.git).This adds
~to the allowed character set in all three validation regexes (fordefault_dotfiles_uri,dotfiles_uri, and thecoder_parametervalidation).Type of Change
Module Information
Path:
registry/coder/modules/dotfilesNew version:
v1.3.1Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
Fixes #762