🤖 fix: disable incomplete markdown parsing for completed content #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remend library (used by streamdown for 'parseIncompleteMarkdown') has a bug where content like $__timeFilter causes trailing '__' to be added to the output. This happens because remend counts all '__' in the entire string without respecting code block boundaries. Fix: Only enable parseIncompleteMarkdown during actual streaming, not for completed/historical content. This prevents the bug while still providing the streaming UX benefit. Root cause: remend@1.0.1 counts markdown emphasis markers (__) globally rather than excluding fenced code blocks, causing false 'repairs'. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The remend library (used by streamdown for
parseIncompleteMarkdown) has a bug where content like$__timeFiltercauses trailing__to be added to the output. This happens because remend counts all__in the entire string without respecting code block boundaries.Fix
Only enable
parseIncompleteMarkdownduring actual streaming, not for completed/historical content. This prevents the bug while still providing the streaming UX benefit.Root Cause
remend@1.0.1counts markdown emphasis markers (__) globally rather than excluding fenced code blocks, causing false 'repairs'.Example buggy input:
Testing
Generated with
mux