Skip to content

feat: add slash command suggestions for provider configuration#8

Closed
ThomasK33 wants to merge 5 commits into
thomask33/10-02-add_type_imports_and_array_syntaxfrom
thomask33/10-01-add_slash_command_suggestions
Closed

feat: add slash command suggestions for provider configuration#8
ThomasK33 wants to merge 5 commits into
thomask33/10-02-add_type_imports_and_array_syntaxfrom
thomask33/10-01-add_slash_command_suggestions

Conversation

@ThomasK33

Copy link
Copy Markdown
Member

Implement slash command suggestion infrastructure to power provider configuration UX.
Replace the command parser with a definition-driven structure and surface a new provider list IPC channel to populate dynamic suggestions.
Add unit tests covering heuristics.

@ammario ammario left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be a lot of formatting changes - can you include the configuration file for the formatter in this change?

Base automatically changed from thomask33/10-01-add_nix_dev_env to main October 1, 2025 18:56
@ThomasK33 ThomasK33 changed the base branch from main to thomask33/10-02-add_type_imports_and_array_syntax October 2, 2025 10:50
@ThomasK33 ThomasK33 force-pushed the thomask33/10-01-add_slash_command_suggestions branch from b6b8ac5 to e836e61 Compare October 2, 2025 10:50
Implement slash command suggestion infrastructure to power provider
configuration UX. Replace command parser with definition driven
structure and surface new provider list IPC channel to
populate dynamic suggestions. Add unit tests covering heuristics.
@ThomasK33 ThomasK33 force-pushed the thomask33/10-02-add_type_imports_and_array_syntax branch from 186ad8f to 0de911c Compare October 2, 2025 10:53
@ThomasK33 ThomasK33 force-pushed the thomask33/10-01-add_slash_command_suggestions branch from e836e61 to f0d0513 Compare October 2, 2025 10:53
@ThomasK33

Copy link
Copy Markdown
Member Author

seems to be a lot of formatting changes - can you include the configuration file for the formatter in this change?

Included them in #10 for easier reviewing and to not colocate formatting changes with this one.

ammario and others added 4 commits October 2, 2025 10:34
- Introduced Config class for test isolation
Resolves merge conflicts from PR #10 which adds:
- Type imports for better code organization
- Array<T> syntax for complex array types
- Prettier schema configuration
- ESLint rules for type imports and array syntax
- Shell formatting script and configuration

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ammario

ammario commented Oct 2, 2025

Copy link
Copy Markdown
Member

Nice little UX improvement -- my code around here needs a bunch of cleanup but ill tackle that soon

@ammario

ammario commented Oct 2, 2025

Copy link
Copy Markdown
Member

(merged in 6ebd8de)

@ammario ammario closed this Oct 2, 2025
@ThomasK33 ThomasK33 deleted the thomask33/10-01-add_slash_command_suggestions branch October 2, 2025 20:59
duynguyen020304 pushed a commit to duynguyen020304/mux that referenced this pull request May 10, 2026
…RY, tests

Batch 1 — Compile Errors & Correctness:
- Add TOGGLE_KANBAN to KEYBIND_LABELS and KEYBIND_GROUPS (coder#1)
- Fix Ctrl+K conflict → Ctrl+Shift+K to avoid PREV_WORKSPACE collision (coder#2)
- Add TOGGLE_KANBAN dispatch handler in App.tsx (coder#3)
- Fix dirty-cache in promoteQueuedTask: move flag clearing after moveTask (coder#5)
- Wrap 4 IPC helpers in KanbanBoard with try/catch (coder#4)

Batch 2 — Consistency & DRY:
- Deduplicate KanbanColumnSchema: import from canonical orpc/schemas (coder#6)
- Remove unused KanbanBoardData import from kanbanStorage.test (coder#7)
- Remove dead KANBAN_STORAGE_KEYS constant (coder#8)
- Replace console.warn with log helper in kanbanStorage (coder#9)
- Replace useEffect form reset with key prop in TaskDetailModal (coder#10)
- Remove unsafe {} as KanbanTask cast, use EMPTY_FORM pattern (coder#11)
- Add loading state + error logging to KanbanView (coder#12, coder#13)
- Add KANBAN_STATUS_LABELS helper, use in TaskDetailModal (coder#14)
- Validate column membership in reorderTasks (coder#15)
- Use KanbanTaskPriority type import in TaskCreateModal (coder#16)

Batch 3 — Tests:
- Add 4 tests for updateColumn (coder#17)
- Add 3 tests for promoteQueuedTask (coder#18)
- Rename misleading test 'rejects empty title' → 'accepts empty title' (coder#19)

43 tests pass (was 36). No typecheck or lint regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants