🤖 fix: prepend mux attribution to provider user-agent#2673
Merged
Conversation
Ensure provider fetch requests prepend mux/<version> to any existing User-Agent so SDK metadata is preserved while mux attribution stays first. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$1.72`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=1.72 -->
Member
Author
|
@codex review |
Member
Author
|
@codex review Please take another look. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepend Mux attribution to outbound provider
User-Agentvalues while preserving SDK-provided metadata.Background
Anthropic requests currently preserve provider SDK
User-Agentvalues. We want Mux attribution to be present first without losing the downstream SDK/runtime detail used for diagnostics.Implementation
buildAIProviderRequestHeadersinsrc/node/services/providerModelFactory.tsto:User-Agenttomux/<version>when absent,mux/<version>when a non-emptyUser-Agentalready exists,src/node/services/providerModelFactory.test.ts:Validation
bun test src/node/services/providerModelFactory.test.tsmake static-checkRisks
Low risk and scoped to request header composition. Main regression surface is user-agent formatting across providers; covered with focused unit tests.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$1.72