🤖 refactor: canonicalize config schema ownership and boundaries by ethanndickson · Pull Request #2649 · coder/mux

ethanndickson · 2026-02-26T07:26:17Z

Summary

This PR centralizes config and shared schema ownership so each schema/enum is defined once in a stable layer, then consumed via re-exports where needed. It removes config↔ORPC dependency inversions, breaks the task-settings circular dependency, and adds lint guardrails to prevent regressions.

Closes #2572.

Background

Recent schema work uncovered several duplication and dependency-boundary problems:

config schemas importing from ORPC schemas
a circular dependency between appConfigOnDisk and types/tasks
duplicated provider/task/log/MCP enums across multiple files
weak boundary enforcement allowing regressions

This refactor makes ownership explicit and aligns consumers around canonical schemas.

Implementation

Added neutral schema modules:
- src/common/schemas/ids.ts
- src/common/schemas/project.ts
Converted ORPC schema modules to consume/re-export canonical ownership where appropriate.
Extracted task settings into a dedicated leaf module:
- src/common/config/schemas/taskSettings.ts
Moved provider model entry schema into config ownership:
- src/common/config/schemas/providerModelEntry.ts
Canonicalized provider enums (cacheTtl, serviceTier, codexOauthDefaultAuth) and reused across ORPC/config.
Removed dead ThinkingLevelSchema re-export from appConfigOnDisk.
Tightened ConfigMutationPathSchema with .max(5).
Deduplicated local enums in api.ts (background process status, log level).
Reused MCPTransportSchema in telemetry instead of a duplicate enum.
Added ESLint boundary rules to prevent ORPC/config import regressions.
Synced generated docs/schemas required by formatting/static-check.

Validation

make static-check
bun test src/common/config/schemas/appConfigOnDisk.test.ts
bun test src/common/config/schemas/providersConfig.test.ts
bun test src/common/orpc/schemas/api.test.ts
bun test src/node/utils/providerRequirements.test.ts
bun test src/node/services/tools/mux_config_write.test.ts

Risks

Low-to-medium: This is broad schema plumbing work touching shared config/ORPC boundaries.
Main mitigations are canonicalized definitions, passing static-check, focused runtime-facing tests, and successful manual settings/agent-flow verification.

Generated with mux • Model: openai:gpt-5.3-codex • Thinking: xhigh • Cost: $53.42

ethanndickson · 2026-02-26T07:27:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb3ae2e8aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/common/orpc/schemas/api.ts

src/node/services/tools/shared/configReadWrite.ts

ethanndickson · 2026-02-26T09:54:44Z

@codex review

ethanndickson · 2026-02-26T09:58:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 699ca46b3c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/tools/shared/configMutationEngine.ts

src/node/services/tools/mux_config_write.ts

ethanndickson · 2026-02-26T12:45:30Z

@codex review

…n validation

…nused schema artifacts

ethanndickson · 2026-02-26T12:49:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 623f33aca2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/tools/shared/configMutationEngine.ts

src/node/services/tools/shared/configReadWrite.ts

…for writes

ethanndickson · 2026-02-26T13:21:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be4c14836e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/node/services/tools/mux_config_read.ts

ethanndickson · 2026-02-26T14:01:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 242bba4040

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-26T14:09:35Z

src/node/services/tools/mux_config_read.ts

+        if (workspaceGuard) return workspaceGuard;
+
+        const muxHome = getMuxHomeFromWorkspaceSessionDir(config, "mux_config_read");
+        const rawDocument = await readConfigDocument(muxHome, args.file);


Allow reading invalid config documents for recovery

mux_config_read currently uses readConfigDocument, which validates the entire file before returning any data. In recovery scenarios this blocks the tool completely—for example, a config containing an out-of-range taskSettings.maxParallelAgentTasks (which mux_config_write is explicitly built to repair) will cause reads to fail with success: false, so the assistant cannot inspect current values before applying a fix. This makes malformed configs much harder to recover from in Chat with Mux.

Useful? React with 👍 / 👎.

mintlify bot deployed to staging - docs February 26, 2026 07:26 View deployment

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

src/common/orpc/schemas/api.ts Outdated Show resolved Hide resolved

src/node/services/tools/shared/configReadWrite.ts Outdated Show resolved Hide resolved

ethanndickson force-pushed the config-schemas-qnqf branch from cb3ae2e to 2d4e5a7 Compare February 26, 2026 07:39

mintlify bot deployed to staging - docs February 26, 2026 07:40 View deployment

ethanndickson force-pushed the config-schemas-qnqf branch from 42e9e62 to 699ca46 Compare February 26, 2026 09:58

mintlify bot deployed to staging - docs February 26, 2026 09:58 View deployment

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

src/node/services/tools/shared/configMutationEngine.ts Show resolved Hide resolved

src/node/services/tools/mux_config_write.ts Show resolved Hide resolved

ethanndickson added 3 commits February 26, 2026 23:49

🤖 refactor: canonicalize config schema ownership and boundaries

6fbe09a

fix: require taskSettings in saveConfig and preserve document shape o…

0adf7f6

…n validation

fix: cap mutation array indices, reject redaction sentinels, remove u…

623f33a

…nused schema artifacts

ethanndickson force-pushed the config-schemas-qnqf branch from 190f862 to 623f33a Compare February 26, 2026 12:49

mintlify bot deployed to staging - docs February 26, 2026 12:50 View deployment

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

src/node/services/tools/shared/configMutationEngine.ts Outdated Show resolved Hide resolved

src/node/services/tools/shared/configReadWrite.ts Show resolved Hide resolved

fix: container-kind-aware path creation and deferred read validation …

be4c148

…for writes

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

src/node/services/tools/mux_config_read.ts Outdated Show resolved Hide resolved

fix: use own-property checks in config path traversal

242bba4

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

Conversation

ethanndickson commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Implementation

Validation

Risks

Uh oh!

ethanndickson commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ethanndickson commented Feb 26, 2026

Uh oh!

ethanndickson commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ethanndickson commented Feb 26, 2026

Uh oh!

ethanndickson commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ethanndickson commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ethanndickson commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ethanndickson commented Feb 26, 2026 •

edited

Loading