🤖 fix: keep agent accents stable on workspace switch#2632
🤖 fix: keep agent accents stable on workspace switch#2632ammar-agent wants to merge 2 commits intomainfrom
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review Updated the agent switcher trigger to restore the compact icon while keeping icon/border colors sourced from the same accent value to prevent loading desync. |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
ammar-agent
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 592ff889f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
1 similar comment
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b924ac1262
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91f9e2c6cb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
agent-switcher-cvp1
branch
from
91f9e2c to
0b69647
Compare
|
@codex review Rebased on latest main and reconciled with recent agent-picker changes. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34ee509383
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1415bba3d6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 457d80148b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
agent-switcher-cvp1
branch
from
457d801 to
1ec3cc6
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Summary
Builds on the upstream agent-switcher fixes now in
mainby adding robust cache hydration rules and shared accent fallback resolution, so workspace switching stays visually stable without introducing invalid cross-scope agent selection.Background
A coworker commit landed on
mainduring review (#2635: auto-cycle exclusion + initial color flash fixes). This branch was rebased/reconciled on top of that work. Remaining gaps were around cache hydration semantics (workspace/project scope leakage) and consistent fallback accents while metadata is pending.Implementation
mainand reconciled overlap with#2635.AgentContextkeyed by:enabled/disabled)enabled/disabled)AgentContexthydrates optimistically from workspace cache first, then project cache, before background refresh.projectvsworkspace) and tightened hydration rules:resolveAgentAccentColor(agentId, discoveredUiColor?)insrc/browser/utils/agents.tswith built-in fallbacks forask,plan,exec,orchestrator, andauto.AgentModePickertrigger border/icon andChatInputfocus border to use shared accent resolution.Validation
bun test src/browser/contexts/AgentContext.test.tsxbun test src/browser/components/AgentModePicker.test.tsxbun x eslint src/browser/contexts/AgentContext.tsx src/browser/components/AgentModePicker.tsx src/browser/components/ChatInput/index.tsx src/browser/utils/agents.ts src/browser/contexts/AgentContext.test.tsx src/browser/components/AgentModePicker.test.tsxmake static-checkRisks
Low-to-moderate UX risk: optimistic project fallback can still be briefly stale across sibling workspaces with divergent custom agents, but fallback visibility/selectability is now scope-aware and live fetch remains authoritative.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$1.07