fix: capitalize productName from "mux" to "Mux"#2596
fix: capitalize productName from "mux" to "Mux"#2596blinkagent[bot] wants to merge 4 commits intomainfrom
Conversation
The electron-builder productName controls the display name shown in OS app lists (e.g. macOS Applications). It was lowercase "mux" while all other apps use capitalized names. Hardcode artifact name prefixes to "mux" to avoid breaking CI workflows and existing download URLs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ece0ca0f00
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The productName change renames the macOS app bundle from mux.app to Mux.app, so the install-mac-arm64 target needs to reference the new name.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
2 participants
The electron-builder
productNamecontrols the display name shown in OS app lists (e.g. macOS Applications, Finder). It was lowercase"mux"while all other apps use capitalized names.This changes
productNameto"Mux"and hardcodes the artifact name prefix tomuxto avoid breaking CI workflows and existing download URLs.Context: link
Before:
muxin OS app listsAfter:
Muxin OS app listsmux-x.y.z-arch.ext)