Draft
Conversation
aslilac
reviewed
Feb 5, 2026
Comment on lines
+7
to
+8
| x86_64_linux: "76e73b8aa2cd67d8618aa6d56060554967704c58f1393133b7b8e783b6ca85f4", | ||
| arm64_linux: "4e0b9fefc123a3fb81fbd91d9e787bdb73813779985dc5cf3f572052def07a83" |
Member
There was a problem hiding this comment.
having identical linux hashes is definitely incorrect
|
|
||
| app "mux.app" | ||
|
|
||
| uninstall quit: "com.mux.app" |
Member
There was a problem hiding this comment.
we definitely do not own mux.com. is this actually our bundle identifier? it should be com.coder.mux instead
Member
Author
|
@aslilac, thanks for the review, and I'm sorry, but this wasn’t meant to be reviewed yet. I need to do a few things on the Mux side first, and didn’t realize it had already turned itself into a PR. My bad 😓 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Mux Homebrew cask to this tap.
Casks/mux.rb(v0.15.2) with per-archsha256values for the GitHub release DMGs.brew audit --cask --strict --online --tap coder/coder muxon macOS PR jobs.brew install --cask coder/coder/mux.📋 Implementation Plan
Plan: Add
muxHomebrew Cask tocoder/homebrew-coderContext / Why
We want
brew install --cask coder/coder/muxto work for the Mux macOS DMG releases, and for future Mux release automation to be able to open PRs against this tap that update onlyversion+sha256.Scope here is only the
coder/homebrew-coder(tap) changes (not the Mux repo workflow/script).Evidence (repo inspection)
Casks/coder-desktop.rbCasks/coder-desktop-preview.rbbrew test-bot --only-tap-syntaxand does not have a dedicated “only casks” mode:.github/workflows/test.yml--only-casks):cmd/test-bot.rbfromHomebrew/homebrew-test-bot(fetched viafunctions.web_fetch).master(remote HEAD):remotes/origin/HEAD -> origin/master.Implementation plan
1) Add the cask:
Casks/mux.rbCreate a new cask file modeled after existing casks in this tap, using per-arch
sha256and the Mux release DMG filename convention.Key decisions to bake in:
arch arm: "arm64", intel: "x64"to match Mux release assets.auto_updates true(Mux uses in-app update via GitHub releases).zap: include only~/Library/...app data by default; do not delete~/.muxunless we explicitly decide to make that a supported “nuclear cleanup”.File shape (fill in real values before merge):
Bootstrapping the initial
version+sha256:v0.15.2):mux-<version>-arm64.dmgmux-<version>-x64.dmgsha256values.2) Validate locally (pre-PR)
On macOS (both architectures if possible):
brew tap coder/coderbrew audit --cask --strict --online --tap coder/coder muxbrew install --cask coder/coder/muxbrew uninstall --cask muxand (optionally)brew uninstall --zap muxto sanity-checkzappaths.3) Ensure PRs get useful CI signal for cask-only changes
Current workflow runs
brew test-bot --only-tap-syntaxand--only-formulaeon PRs (see.github/workflows/test.yml).brew test-botdoesn’t have an--only-casksmode, so cask changes may only get syntax validation.Recommended adjustment (small, cask-focused):
brew audit --cask --strict --online --tap coder/coder muxstep on the macOS runner for PRs.4) (Optional) Documentation tweak
Add a short “Install Mux” snippet to
README.md:Acceptance criteria
Casks/mux.rbexists and passesbrew audit --cask --strict --online --tap coder/coder mux.brew install --cask coder/coder/muxinstalls and launches Mux successfully.Generated with
mux• Model:openai:gpt-5.2• Thinking:xhigh