-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove codersdk dependency #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we anticipate we will be in this state for some time? If so, a README
in the notcodersdk
would be helpful for archaeological purposes. Optionally one step further would be to add a script to clone the repo and lint to ensure we aren't drifting too far from the original repo, but this may be overkill for now.
#193 exists to investigate removing this direct dependency. Hopefully as a result of either that or another follow-up PR we can then remove this entirely.
This is a good idea either way 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notcodersdk
This sounds sneaky. 😂
Part of #178
In order to update our branch of Kaniko, we need to first update to go1.22.
This is not currently possible while depending on codersdk.
codersdk
andagentsdk
intointernal/notcodersdk
codersdk
/agentsdk
withinternal/notcodersdk
Before:
After: