chore: add docs re docker inside envbuilder-built-envs #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
May 15, 2024
docs/docker.md
Outdated
| ghcr.io/coder/envbuilder:latest | ||
| ``` | ||
|
|
||
| This can also be accomplished using the [`docker-in-docker` Devcontainer feature](https://github.com/devcontainers/features/tree/main/src/docker-in-docker). |
There was a problem hiding this comment.
Just off the top of my head, this won't work OOTB, envbuilder doesn't run the entrypoint defined here:
Mounts may also require special consideration. 🤔
There was a problem hiding this comment.
Yeah, the custom entrypoint is still required here. 👍
There was a problem hiding this comment.
We should point it out here, otherwise we open ourselves up to support requests for feature X not working.
Later on, we should think about how we can support launching these entrypoints from envbulider.
There was a problem hiding this comment.
I added a separate example 03_dind_feature for this. Works fine with volume mounts as far as I tested, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
TODO: add equivalent
kubectlinvocations