Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: locate devcontainer.json in multiple places #134

Merged
merged 6 commits into from
Apr 23, 2024
Merged

feat: locate devcontainer.json in multiple places #134

merged 6 commits into from
Apr 23, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Apr 22, 2024 •
edited
Loading

Fixes: #116

This PR extends the logic responsible for locating the devcontainer.json manifest to check in multiple locations.

@mtojek mtojek self-assigned this Apr 22, 2024
@mtojek mtojek marked this pull request as draft April 22, 2024 12:32
@mtojek mtojek marked this pull request as ready for review April 22, 2024 14:12
johnstcn
johnstcn approved these changes Apr 22, 2024
View reviewed changes
envbuilder.go Show resolved Hide resolved
@mtojek mtojek merged commit ece89cd into main Apr 23, 2024
2 checks passed
@mtojek mtojek deleted the 116-search branch April 23, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not search all specified devcontainer locations
2 participants
@mtojek @johnstcn